fix: map bizhawk's ares to its n64 core only

BizHawk embeds ares as Ares64, its N64 core, whose 64DD IPL its own
FirmwareDatabase declares. Mapped to the whole ares profile, it pulled
thirty systems into the BizHawk pack and made slots accuse
FirmwareDatabase.cs of a wrong MSX.rom it never declared for ares.
This commit is contained in:
Abdessamad Derraz committed 2026-10-17 10:39:27 +02:00
1 parent af4b43d64c
commit 83d8f62f68
4 files changed
+18 -3

No files matched your search

-1
View File
@@ -413,7 +413,6 @@ platforms:
schedule: monthly
cores:
- applewin
- ares
- azahar
- beetle_ngp
- beetle_pce
-1
View File
@@ -26,7 +26,6 @@ cores:
- handy
- quicknes
- genesis_plus_gx
- ares
- mupen64plus_next
- puae
- prboom
+3 -1
View File
@@ -127,7 +127,9 @@ BIZHAWK_CORES = [
"handy",
"quicknes",
"genesis_plus_gx",
"ares",
# Ares64 is BizHawk's N64 core only; its firmware (the 64DD IPL) is in
# FirmwareDatabase.cs. The ares profile's thirty systems are not what
# BizHawk runs ares for.
"mupen64plus_next",
"puae",
"prboom",
+15
View File
@@ -331,6 +331,21 @@ class RetroDeckCoresAreItsComponents(unittest.TestCase):
self.assertNotIn("cores", registry["platforms"]["retrodeck"])
class BizHawkRunsAresForN64Only(unittest.TestCase):
"""BizHawk embeds ares as Ares64, its N64 core; mapping it to the ares
profile claimed thirty systems and accused FirmwareDatabase.cs of a
wrong MSX.rom it never declared for ares."""
def test_ares_is_not_a_bizhawk_core(self):
import yaml
root = Path(__file__).resolve().parents[1]
platform = yaml.safe_load((root / "platforms" / "bizhawk.yml").read_text())
registry = yaml.safe_load((root / "platforms" / "_registry.yml").read_text())
self.assertNotIn("ares", platform["cores"])
self.assertNotIn("ares", registry["platforms"]["bizhawk"]["cores"])
class UnreadableReleaseStopsTheScrape(unittest.TestCase):
"""A failed tag lookup fell back to master, or to an empty or invented
version. BizHawk, RomM, Batocera and Recalbox then wrote a YAML read from