fix: name the offline screen for what it does

install.py reads the file list before it checks a single file, so
without a connection nothing is checked: the screen says No connection
and offers to check again.
This commit is contained in:
Abdessamad Derraz committed 2026-10-22 03:59:56 +02:00
1 parent 7d87828b98
commit 8a7e5aa829
2 files changed
+2 -2

No files matched your search

+1 -1
View File
@@ -254,7 +254,7 @@ rb_screen_problem() {
elif [ "$RB_DETECTED" = "0" ]; then
rb_notice "No BIOS folder found" "install.py knows no BIOS folder on $RB_OS_NAME. $RB_PC_ROUTE" "check" "Check again" "quit" "Quit"
elif [ "$RB_ERROR" = "network" ]; then
rb_notice "No connection: checking only" "$RB_OS_NAME, BIOS folder $RB_BIOS_DIR. The list of files to check comes from the internet, and so do the files. Connect to Wi-Fi, then check again." "check" "Check again" "quit" "Quit"
rb_notice "No connection" "$RB_OS_NAME, BIOS folder $RB_BIOS_DIR. The list of files to check comes from the internet, and so do the files: without a connection nothing can be checked or downloaded. Connect to Wi-Fi, then check again." "check" "Check again" "quit" "Quit"
elif [ "$RB_ERROR" = "invalid" ]; then
rb_notice "The file list is newer than this port" "$RB_ERROR_TEXT. Update RetroBIOS from PortMaster, or use the installer on a computer. $RB_PC_ROUTE" "check" "Check again" "quit" "Quit"
else
+1 -1
View File
@@ -382,7 +382,7 @@ class TheScreens(unittest.TestCase):
shown = self.run_port("offline", ["quit"])
self.assertEqual(self.lists(shown), [("notice", ["info", "check", "quit"])])
notice = shown[[s[0] for s in shown].index("list")][2]
self.assertEqual(notice["info"][0], "No connection: checking only")
self.assertEqual(notice["info"][0], "No connection")
self.assertIn("Connect to Wi-Fi", notice["info"][1])
self.assertIn("/roms/bios", notice["info"][1])