mirror of
https://github.com/Abdess/retroarch_system.git
synced 2026-11-11 12:33:53 -06:00
Abdessamad Derraz
057fd2d0f6
tests/__init__.py keeps a run offline, its scratch under tmp/ and its installer cache its own, but only discover -s tests -t . imported it. discover tests ran with RETROBIOS_OFFLINE unset, scratch on the /tmp tmpfs and the user's real installer cache, the setting in which e2e fixtures had written into the shared .cache/large. Every test module now imports the package first, and a test fails on a module that does not. test_verify_listing.py took its line with the previous commit.
49 lines
1.9 KiB
Python
49 lines
1.9 KiB
Python
"""A dataclass field typed as a container defaults to an empty one.
|
|
|
|
ProfileReport declared `entries: list[EntryReport] = None`: the annotation
|
|
promised a list, the public constructor gave None, and format_report raised
|
|
TypeError on the first loop.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import tests # noqa: F401 offline, scratch under tmp/, the suite's own cache
|
|
|
|
import ast
|
|
import unittest
|
|
from pathlib import Path
|
|
|
|
REPO_ROOT = Path(__file__).resolve().parents[1]
|
|
|
|
|
|
def _is_dataclass(node: ast.ClassDef) -> bool:
|
|
for deco in node.decorator_list:
|
|
target = deco.func if isinstance(deco, ast.Call) else deco
|
|
name = target.attr if isinstance(target, ast.Attribute) else getattr(target, "id", "")
|
|
if name == "dataclass":
|
|
return True
|
|
return False
|
|
|
|
|
|
class ContainerFieldsAreNotNone(unittest.TestCase):
|
|
def test_no_container_annotation_defaults_to_none(self):
|
|
for path in sorted([*(REPO_ROOT / "scripts").rglob("*.py"), REPO_ROOT / "install.py"]):
|
|
tree = ast.parse(path.read_text(encoding="utf-8"))
|
|
for node in ast.walk(tree):
|
|
if not (isinstance(node, ast.ClassDef) and _is_dataclass(node)):
|
|
continue
|
|
for stmt in node.body:
|
|
if not isinstance(stmt, ast.AnnAssign) or stmt.value is None:
|
|
continue
|
|
annotation = ast.unparse(stmt.annotation)
|
|
is_none = isinstance(stmt.value, ast.Constant) and stmt.value.value is None
|
|
if is_none and annotation.split("[")[0] in ("list", "dict", "set") \
|
|
and "None" not in annotation:
|
|
with self.subTest(module=path.name, cls=node.name,
|
|
field=ast.unparse(stmt.target)):
|
|
self.fail(f"{annotation} defaults to None")
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|