mirror of
https://github.com/Abdess/retroarch_system.git
synced 2026-11-06 10:03:49 -06:00
fix: hint at --verbose when no bundled name shows
With no required firmware among the bundled entries the line read '20 (20 more, --verbose lists them)'. It now reads '20 (--verbose lists them)', and reading-reports.md quotes the run as it prints.
This commit is contained in:
1 parent
1b4b31fb32
commit
7dcb427e27
3 files changed
+10
-2
No files matched your search
+2
-1
@@ -1904,7 +1904,8 @@ def _print_undeclared_section(result: dict, verbose: bool) -> None:
|
||||
# The required firmware alone read as the whole count: 14 names
|
||||
# for 154 entries, nothing saying the rest existed.
|
||||
hidden = len({u["name"] for u in bundled}) - len(named)
|
||||
items = named + ([f"{hidden} more, --verbose lists them"] if hidden else [])
|
||||
more = f"{hidden} more, " if named else ""
|
||||
items = named + ([f"{more}--verbose lists them"] if hidden else [])
|
||||
print(
|
||||
f" Bundled with their emulator, not collected: {len(bundled)}"
|
||||
+ (f" ({', '.join(items)})" if items else "")
|
||||
|
||||
@@ -2,6 +2,8 @@
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import tests # noqa: F401 offline, scratch under tmp/, the suite's own cache
|
||||
|
||||
import subprocess
|
||||
import sys
|
||||
import unittest
|
||||
@@ -270,6 +272,11 @@ class TheBundledLineSaysWhatItLeavesOut(unittest.TestCase):
|
||||
"Bundled with their emulator, not collected: 3 (a.frag, b.dll, fw.bin)",
|
||||
verbose.getvalue(),
|
||||
)
|
||||
result["undeclared_files"] = result["undeclared_files"][1:]
|
||||
with contextlib.redirect_stdout(io.StringIO()) as unnamed:
|
||||
verify._print_undeclared_section(result, verbose=False)
|
||||
self.assertIn("Bundled with their emulator, not collected: 2 (--verbose lists them)",
|
||||
unnamed.getvalue())
|
||||
|
||||
|
||||
class TheCheckLineSaysWhatItIs(unittest.TestCase):
|
||||
|
||||
@@ -110,7 +110,7 @@ RetroDECK: 2007/2008 OK, 1 untested [md5]
|
||||
Core files: 1764 in pack, 1 required missing, 26 optional missing (--verbose lists them)
|
||||
Core files held but not packed: 154 (142 installed with its emulator, 8 read below a save folder per system and no system runs the core there, 4 a packed file occupies its directory)
|
||||
MISSING (required): FinalBurn Neo needs sfiii2a.zip (1 file)
|
||||
Bundled with their emulator, not collected: 20
|
||||
Bundled with their emulator, not collected: 20 (--verbose lists them)
|
||||
Game data: 5099 in pack, 30 missing (--verbose lists them)
|
||||
Game data held but not packed: 30 (installed with its emulator)
|
||||
No external files: 78 cores (--verbose lists them)
|
||||
|
||||
Reference in new issue
Block a user