fix: drop RMG launcher names from Mupen64Plus

IPL_USA.n64 and IPL_DEV.n64 are the names RetroBat's mupen64 generator
writes for Rosalie's Mupen GUI (Mupen64.Generator.cs:232-238).
Mupen64Plus, Mupen64Plus-AE and M64Plus FZ fix no IPL name: the path
comes from the IPL-ROM key or --dd-ipl-rom, then the Android front ends
copy the chosen file to dd_rom.n64.
This commit is contained in:
Abdessamad Derraz committed 2026-11-06 15:22:10 +01:00
1 parent ed6643022d
commit 8a48156830
4 files changed
+18 -6

No files matched your search

+2 -2
View File
@@ -148,7 +148,7 @@ files:
source_ref: "app/src/main/java/paulscode/android/mupen64plusae/jni/CoreService.java:599-612,621-623, app/src/main/java/paulscode/android/mupen64plusae/jni/CoreInterface.java:455-484, app/src/main/java/paulscode/android/mupen64plusae/persistent/GlobalPrefs.java:417,715, mupen64plus-core/upstream/src/main/main.c:1080-1145"
- name: "64DD_IPL_US.n64"
aliases: ["64DD_IPL_USA.bin", "IPL_USA.n64"]
aliases: ["64DD_IPL_USA.bin"]
system: nintendo-64dd
required: true
validation: [signature]
@@ -163,7 +163,7 @@ files:
source_ref: "app/src/main/java/paulscode/android/mupen64plusae/util/RomHeader.java:180-212, app/src/main/java/paulscode/android/mupen64plusae/jni/CoreInterface.java:221,455-484, mupen64plus-core/upstream/src/main/main.c:1080-1145"
- name: "64DD_IPL_DEV.n64"
aliases: ["64DD_IPL_DEV.bin", "IPL_DEV.n64"]
aliases: ["64DD_IPL_DEV.bin"]
system: nintendo-64dd
required: true
validation: [signature]
+2 -2
View File
@@ -148,7 +148,7 @@ files:
source_ref: "app/src/main/java/paulscode/android/mupen64plusae/jni/CoreService.java:606-620,638-639, app/src/main/java/paulscode/android/mupen64plusae/jni/CoreInterface.java:459-488, app/src/main/java/paulscode/android/mupen64plusae/persistent/GlobalPrefs.java:421,727, mupen64plus-core/upstream/src/main/main.c:1080-1145"
- name: "64DD_IPL_US.n64"
aliases: ["64DD_IPL_USA.bin", "IPL_USA.n64"]
aliases: ["64DD_IPL_USA.bin"]
system: nintendo-64dd
required: true
validation: [signature]
@@ -163,7 +163,7 @@ files:
source_ref: "app/src/main/java/paulscode/android/mupen64plusae/util/RomHeader.java:180-220, app/src/main/java/paulscode/android/mupen64plusae/jni/CoreInterface.java:223,459-488, mupen64plus-core/upstream/src/main/main.c:1080-1145"
- name: "64DD_IPL_DEV.n64"
aliases: ["64DD_IPL_DEV.bin", "IPL_DEV.n64"]
aliases: ["64DD_IPL_DEV.bin"]
system: nintendo-64dd
required: true
validation: [signature]
+2 -2
View File
@@ -89,7 +89,7 @@ files:
source_ref: "src/main.c:321, src/main.c:729-732, src/main.c:874-877, upstream src/main/main.c:1183-1248"
- name: "64DD_IPL_US.n64"
aliases: ["64DD_IPL_USA.bin", "IPL_USA.n64"]
aliases: ["64DD_IPL_USA.bin"]
system: nintendo-64dd
required: true
unread_on: [amberelec]
@@ -98,7 +98,7 @@ files:
source_ref: "src/main.c:874-892, upstream src/main/main.c:1183-1248"
- name: "64DD_IPL_DEV.n64"
aliases: ["64DD_IPL_DEV.bin", "IPL_DEV.n64"]
aliases: ["64DD_IPL_DEV.bin"]
system: nintendo-64dd
required: true
unread_on: [amberelec]
+12
View File
@@ -119,6 +119,18 @@ class ProfileAliasesAreCodeNames(unittest.TestCase):
"code, stated in the entry's note with its source_ref, or removed",
)
def test_rosalies_mupen_gui_names_stay_out_of_mupen64plus(self) -> None:
"""RetroBat's mupen64 generator configures Rosalie's Mupen GUI and
writes IPL_USA.n64 and IPL_DEV.n64 into its config
(Mupen64.Generator.cs:232-238). Mupen64Plus fixes no IPL name."""
profiles = _profiles()
for key in ("mupen64plus", "mupen64plus-ae", "m64plus-fz"):
aliases = {
str(a) for entry in profiles[key].get("files") or []
for a in entry.get("aliases") or []
}
self.assertFalse(aliases & {"IPL_USA.n64", "IPL_DEV.n64"}, key)
def test_check_catches_a_launcher_name(self) -> None:
self.assertFalse(_named_without_platform(
"cerbios.bin", "Batocera writes bios/cerbios.bin into flashrom_path.",